Add providers for signing config and legacy helper #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
addproviders
branch
from
ad36d5b to
18b3a47
Compare
aaronlew02
reviewed
May 23, 2025
sigstore-java/src/main/java/dev/sigstore/SigningConfigProvider.java
Outdated
Show resolved
Hide resolved
And some other minor associated changes Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
addproviders
branch
from
18b3a47 to
b1cce2f
Compare
aaronlew02
approved these changes
May 23, 2025
| return () -> { | ||
| try { | ||
| SigstoreTufClient tufClient = tufClientBuilder.build(); | ||
| tufClient.update(); |
There was a problem hiding this comment.
Just wondering, does this always have to be called after building a tuf client? Could it be automatic based on if the timestamp is expired?
|
|
||
| // Temporary while the tuf repos catches up, this will still fail if the remove TUF isn't | ||
| // available to check for signing config | ||
| static SigningConfigProvider fromOrDefault( |
There was a problem hiding this comment.
What's the advantage of this method over catching if from(tuf) fails and initializing a SigstoreSigningConfig?
| var fromTuf = tufClient.getSigstoreSigningConfig(); | ||
| return fromTuf == null ? defaultConfig : fromTuf; | ||
| } catch (IOException ex) { | ||
| throw new SigstoreConfigurationException( |
There was a problem hiding this comment.
You could return defaultConfig if not null on error?
| static final URI DEX_PUBLIC_GOOD_URI = URI.create("https://oauth2.sigstore.dev/auth"); | ||
| static final URI DEX_STAGING_GOOD_URI = URI.create("https://oauth2.sigstage.dev/auth"); | ||
|
|
||
| static final URI TSA_PUBLIC_GOOD_URI = URI.create("https://tsa.sigstore.dev"); |
There was a problem hiding this comment.
For the TSA, can this be the full path rather than just the host? The TSA client shouldn't assume that the path is the same for all TSAs, so that callers can use other TSAs besides the sigstore/timestamp-authority implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some other minor associated changes as part #954