Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix justification of alternates #726

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix justification of alternates #726

wants to merge 3 commits into from

Conversation

alerque
Copy link
Member

@alerque alerque commented Nov 30, 2019

Fixes #724.

Opening PR because I don't know what the status is beyond what the commit messages say, but its a lot easier to track with a PR than just a branch. For example this way I can get notifications when commits are added.

@simoncozens
refactor(debug): Improve debugging of line breaking engine, particula…
f834c54 
…rly around alternates
@simoncozens
fix(core): Delay recording of alternate selections until new active n…
3556320 
…ode is created

This goes some way to mitigating #724, but I think more work is needed. It looks good for the first line, but we also need to check alternates are correctly applied on subsequent lines.
@simoncozens
Copy link
Member

Thanks. I think this is more or less on the right track but I am working on more tests.

@simoncozens
fix(packages): Tests for bug #724
9ccdca2 
Updates to the justification alternates support. Closes #724.
simoncozens added a commit that referenced this pull request Jan 11, 2020
@simoncozens
improvement(packages): Fix alternates
eaaee9e 
(See also #726)
@Omikhleia
Copy link
Member

Omikhleia commented Oct 22, 2024 •
edited
Loading

This 5+ year old PR never came to fruition as-is and now has conflicts.
Due to inactivity, and as part of backlog cleaning, I would have been tempted to close it, but the topic was interesting, and the reasons why it didn't eventually occur are unclear.
So I'm adding the "pending closure" as a label - As a last chance for contributors to eventually say their word.
After some period of time, this inactive PR will be closed without further notice.

@Omikhleia Omikhleia added the pending closure Backlog cleaning (inactive non bug-issues) label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simoncozens simoncozens

Labels
pending closure Backlog cleaning (inactive non bug-issues)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Justification alternates system is broken
3 participants
@alerque @simoncozens @Omikhleia