Word Export: prevent cross-thread exception

[mark-sil]

When disposing the ClerkActivator do not update the status bar in the call to ActivateUI().
XHTML export is also calling this from a different thread but we were not seeing this error because the text string was the same as the current value so no change was made.
Notes:
In OnExport(), after the command completes, we call ActivateUI() a second time, and this time we do update the status bar.
The exception was only happening when there were reversals and it seemed to only/mostly happen in debug builds.

Change-Id: Ife8957181e5a07736b1f56e2f488aa92c8f226c5

---

This change is 

[jasonleenaylor]

Src/xWorks/DictionaryExportService.cs line 194 at r1 (raw file):

				System.Diagnostics.Debug.WriteLineIf(!disposing, "****** Missing Dispose() call for " + GetType() + " ******");
				if (disposing && m_currentClerk != null && !m_currentClerk.IsDisposed)
					m_currentClerk.ActivateUI(true, false);

So if this is an exception that is happening because it is trying to modify winforms UI code from a different thread there is a more robust solution closer to where the control is modified. Every control has an InvokeRequired property that tells you if you are trying to execute something on the wrong thread. You can then use an Invoke method to get it to execute the code you want.

[jasonleenaylor]

Lets look at another option first.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

[mark-sil]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

Src/xWorks/DictionaryExportService.cs line 194 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

So if this is an exception that is happening because it is trying to modify winforms UI code from a different thread there is a more robust solution closer to where the control is modified. Every control has an InvokeRequired property that tells you if you are trying to execute something on the wrong thread. You can then use an Invoke method to get it to execute the code you want.

I implemented the solution you suggested. Much better, thanks!

[mark-sil]

I implemented the solution you suggested.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

[jasonleenaylor]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)