Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-21053: Update homographs to match publication #251

Open
wants to merge 2 commits into
base: release/9.1
Choose a base branch
from

Conversation

JakeOliver28
Copy link
Contributor

@JakeOliver28 JakeOliver28 commented Jan 22, 2025

This change is Reviewable

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) January 22, 2025 22:02
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved


Src/xWorks/ConfiguredLcmGenerator.cs line 459 at r1 (raw file):

				// This code demonstrates using the cache metadata,
				// an alternative form of reflection to get values that respect the decorator
				// We may be able to replace the GetValueFromMember above with this code, but the ownerClassName may take

This comment is no longer necessary, since we did it.


Src/xWorks/ConfiguredLcmGenerator.cs line 457 at r1 (raw file):

					return settings.ContentGenerator.CreateFragment();
				}
				propertyValue = GetValueFromMember(property, field);

If GetValueFromMember had no other uses it can be deleted as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants