-
-
Notifications
You must be signed in to change notification settings - Fork 9
[frontend] Migrate away from deprecated Grid #3787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imnasnainaec
wants to merge
26
commits into
master
Choose a base branch
from
grid2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
- Coverage 72.92% 72.90% -0.03%
==========================================
Files 286 286
Lines 10771 10764 -7
Branches 1340 1344 +4
==========================================
- Hits 7855 7847 -8
- Misses 2516 2518 +2
+ Partials 400 399 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for review:
<Grid>
with<Grid2>
,<Stack>
,<Box>
,<div>
, or nothing, as fit the design need.<Stack direction="row">
can be used in place of<Grid2>
when we don't want the items in the row to wrap to a second row in a narrow window<Grid>
/<List>
combo with a<Table>
inDomainStatistics
&UserStatistics
components<Card>
layout was made more consistent acrossInvalidLink
,Login
,Signup
,ResetRequest
, &PasswordReset
CharInv
into child componentCharacterEntry
at topmaster
(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsResetRequest
; initiate a password reset and click the link sent to your email to testPasswordReset
; change a character in the token within that url to testInvalidLink
UploadImage
andViewImageDialog
(respectively):*Completed
components by clicking a completed goal tile in Data Cleanup under "You've completed:"CharInvCompleted
, first go to Data Cleanup > Create Character Inventory, click on any character tile with multiple occurrences, and do a Find & ReplaceMergeDupsCompleted
, first go to Data Cleanup > Merge Duplicates, and merge and/or delete words in various combinationsWordCard
andReviewEntriesCompleted
, first go to Data Cleanup > Review Entries and edit several entries, including adding multiple semantic domains to a senseSiteSettings
by logging in with a site admin (https://github.com/sillsdev/TheCombine?tab=readme-ov-file#grant-admin-rights), then click your avatar to open theUserMenu
and the top option will be "Site Settings"This change is