First attempt at making IChangeContext interface #26
Conversation
| @@ -15,7 +16,7 @@ | |||
| Commit = commit; | |||
| } | |||
|
|
|||
| public Commit Commit { get; } | |||
| public Commit Commit { get; } // PROBLEM: Interface is CommitBase. How do I do this? | |||
There was a problem hiding this comment.
you can just change the property type from Commit to CommitBase
|
|
||
| namespace SIL.Harmony.Core; | ||
|
|
||
| public class ObjectSnapshot |
There was a problem hiding this comment.
it looks like actually moving this would be more painful than I expected. There's also the fact that since it's stored in the Db changing the Commit type might cause problems there. Instead lets just extract an interface. It should have all the properties but the Commit type will be CommitBase on the interface. We then need to make an explicit interface implementation on ObjectSnapshot. That looks like this:
CommitBase IObjectSnapshot.Commit => Commit, this basically makes this Commit property only get used if the object is referred to as IObjectSnapshot if it's referred to as ObjectSnapshot then it will use the public property.
| @@ -15,7 +16,7 @@ | |||
| Commit = commit; | |||
| } | |||
|
|
|||
| public Commit Commit { get; } | |||
| public Commit Commit { get; } // PROBLEM: Interface is CommitBase. How do I do this? | |||
| public async ValueTask<ObjectSnapshot?> GetSnapshot(Guid entityId) => await _worker.GetSnapshot(entityId); | |||
| public async ValueTask<T?> GetCurrent<T>(Guid entityId) where T : class | |||
| { | |||
There was a problem hiding this comment.
[Re: line +29]
this doesn't compile, it'll need to change to an explicit implementation IObjectBase IChangeContext.Adapt(object obj)
See this comment inline on Graphite.
Attempting to fix #23. Two problems so far: