-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split developer docs into per-OS files #1305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wanted us to recommend native docker for Linux users, so I wrote a paragraph explaining why this project recommends Docker Desktop on Linux even though native docker is available. The other recommendations were good (typo and grammar fixes).
On Linux (only), Docker Desktop tends to spam the syslog with debug-level messages about HTTP requests and responses. We should provide instructions on how to silence that spam so Linux devs' /var partitions don't fill up unexpectedly fast.
@rmunn How would you feel about only using the os-specific files for os-specific details? That would:
|
This removes some of the redundancy between the OS-specific files and the main one. We also note that the Mac instructions are likely incomplete.
hahn-kev
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1265.
Fix #1260.