Fixed problems in GetSafeDirectories and GetDirectoryDistributedWithApplication #1370
+91
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory the user does not have permission to access. In GetDirectoryDistributedWithApplication, prevented a failure in accessing one of the specified subfolders from allowing it to try the others.
# Conflicts: # CHANGELOG.md
ermshiperete
approved these changes
Jan 6, 2025
…ur with one or more folders. Also fixed some typos and did other minor code cleanup in Logger.cs
tombogle
commented
Jan 6, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @ermshiperete and @FoolRunning)
ermshiperete
approved these changes
Jan 7, 2025
ermshiperete
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @FoolRunning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a user does not have access to any one directory under consideration, these methods would fail/crash without considering the remaining directories.
This change is