Skip to content

Commit

Permalink
Fix NG0955 warnings in unit tests (#2968)
Browse files Browse the repository at this point in the history
  • Loading branch information
pmachapman authored Jan 21, 2025
1 parent c5ca852 commit 44aa8bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,14 @@ describe('DraftGenerationStepsComponent', () => {
trainingSources: [
{
projectRef: 'source1',
paratextId: 'PT_SP1',
shortName: 'sP1',
writingSystem: { tag: 'eng' },
texts: availableBooks.concat({ bookNum: 1 })
},
{
projectRef: 'source2',
paratextId: 'PT_SP2',
shortName: 'sP2',
writingSystem: { tag: 'eng' },
texts: availableBooks.concat({ bookNum: 6 })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { DialogService } from 'xforge-common/dialog.service';
import { createTestFeatureFlag, FeatureFlagService } from 'xforge-common/feature-flags/feature-flag.service';
import { I18nService } from 'xforge-common/i18n.service';
import { Locale } from 'xforge-common/models/i18n-locale';
import { RealtimeQuery } from 'xforge-common/models/realtime-query';
import { UserDoc } from 'xforge-common/models/user-doc';
import { NoticeService } from 'xforge-common/notice.service';
import { OnlineStatusService } from 'xforge-common/online-status.service';
Expand All @@ -26,7 +27,6 @@ import { TestOnlineStatusService } from 'xforge-common/test-online-status.servic
import { TestTranslocoModule } from 'xforge-common/test-utils';
import { UICommonModule } from 'xforge-common/ui-common.module';
import { UserService } from 'xforge-common/user.service';
import { RealtimeQuery } from '../../../xforge-common/models/realtime-query';
import { SFProjectProfileDoc } from '../../core/models/sf-project-profile-doc';
import { TrainingDataDoc } from '../../core/models/training-data-doc';
import { SFProjectService } from '../../core/sf-project.service';
Expand Down Expand Up @@ -2256,7 +2256,7 @@ describe('DraftGenerationComponent', () => {
expect(env.downloadButton).not.toBeNull();
});

it('button should not display if there is no completed build while a build is faulter', () => {
it('button should not display if there is no completed build while a build is faulted', () => {
const env = new TestEnvironment();
env.component.draftJob = { ...buildDto, state: BuildStates.Faulted };
env.component.lastCompletedBuild = undefined;
Expand Down

0 comments on commit 44aa8bd

Please sign in to comment.