SF-3111 Fix question dialog verse reference error message overlap #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaymondLuong3
added
the
will require testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
=======================================
Coverage 82.06% 82.06%
=======================================
Files 544 544
Lines 31630 31630
Branches 5146 5124 -22
=======================================
Hits 25956 25956
Misses 4917 4917
Partials 757 757 ☔ View full report in Codecov by Sentry. |
pmachapman
force-pushed
the
fix/sf-3111-dialog-overlap
branch
from
750ea7d to
5ce4407
Compare
pmachapman
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
SubscriptionDisposable!
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)
pmachapman
added
ready to test
and removed
will require testing
Nateowami
added
testing complete
Nateowami
force-pushed
the
fix/sf-3111-dialog-overlap
branch
from
5ce4407 to
8c19c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message in the text input has the
position: absoluterule applied. So it is expected to show over top of anything that comes below. In this case, this rule makes it hard to know how much space below the input to give. I've given it the minimum so that it shows nicely. FWIW, I would not mind if we just left the error message overlap as by design.Before
After
This change is