-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-3170 Show a summary message when no training books are selected #2971
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2971 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 544 544
Lines 31623 31623
Branches 5122 5139 +17
=======================================
Hits 25949 25949
+ Misses 4917 4905 -12
- Partials 757 769 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @josephmyers)
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html
line 215 at r1 (raw file):
<mat-card class="confirm-section mat-elevation-z2"> @if (selectedTrainingBooksCollapsed().length === 0) { <span>No training books selected</span>
I18n
78c8efc
to
8bc858b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Nateowami)
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html
line 215 at r1 (raw file):
Previously, Nateowami wrote…
I18n
Oops, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @josephmyers)
I opted for a minimalistic solution here, because this seems to be a rare use case, based on a conversation with Nathaniel. We need to support it, but most target languages won't be in the NLLB. We can certainly do more with the UI -- on the Summary and Training pages -- but apparently it's not necessary to guide them down this path too forcefully.
This change is