Add missing lastSelectedTranslationScriptureRanges property to TypeScript DraftConfig and schema #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmachapman
force-pushed
the
fix/translation-scripture-ranges
branch
from
1b513d1 to
260c7e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2976 +/- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 544 544
Lines 31637 31644 +7
Branches 5147 5147
=======================================
+ Hits 25969 25976 +7
Misses 4901 4901
Partials 767 767 ☔ View full report in Codecov by Sentry. |
pmachapman
force-pushed
the
fix/translation-scripture-ranges
branch
from
2e9acf6 to
ac4ba21
Compare
Nateowami
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this property was missing when I ran data model validations on the server. I am not sure how these got missed, but a unit test pass will be sufficient before merging.
I also took this opportunity to add all project types supported by Scripture Forge, as one of these (XmlDictionary) caused validation to fail on live.
This change is