Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3180 Update linked url's to specific help site pages #2981

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kylebuss
Copy link
Collaborator

@kylebuss kylebuss commented Jan 28, 2025

There are recent changes to the SF Help Site that would result in broken links from the app. This PR updates those links and will need to be live before we can deploy the latest version of the Help Site.

The local and qa environments have also been updated to point to the preview site rather than the live site so the new links can be tested that they resolve to the correct page/section. I've marked this as "testing not required" as a test/review of the links by a developer should be sufficient.


This change is Reviewable

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (f7aada1) to head (811715c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2981   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files         544      544           
  Lines       31697    31697           
  Branches     5127     5155   +28     
=======================================
  Hits        26005    26005           
+ Misses       4937     4925   -12     
- Partials      755      767   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this Jan 28, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I am guessing there will be a second PR coming when the site goes live and we can replace the links to it? I'm happy to merge this in, but I wonder if the site is ready and stable, could we not publish the site and just update the urls here?

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kylebuss)

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kylebuss)

@RaymondLuong3 RaymondLuong3 force-pushed the task/update-help-site-urls branch from db8945d to 811715c Compare January 28, 2025 21:31
@RaymondLuong3 RaymondLuong3 merged commit fd6844f into master Jan 28, 2025
17 checks passed
@RaymondLuong3 RaymondLuong3 deleted the task/update-help-site-urls branch January 28, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants