Skip to content

SF-3370 Improve lynx processing time when opening large projects #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

siltomato
Copy link
Collaborator

@siltomato siltomato commented May 16, 2025

This PR improves the processing of lynx diagnostics before emitting as rawInsightSource$, particularly adding a debounce to avoid emitting after each event URI (text doc id) when loading a new project.

You can test the loading speed by opening a DBL resource like 'NTV' with lynx enabled in QA vs this branch.

The problems panel still is slow to switch with many insights, but that will be improved in a separate PR.


This change is Reviewable

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (310bffd) to head (b2209fd).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ate/editor/lynx/insights/lynx-workspace.service.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3207   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         601      601           
  Lines       34496    34500    +4     
  Branches     5595     5596    +1     
=======================================
+ Hits        28237    28241    +4     
+ Misses       5438     5426   -12     
- Partials      821      833   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@siltomato siltomato marked this pull request as ready for review May 16, 2025 23:33
@pmachapman pmachapman self-requested a review May 18, 2025 21:34
@pmachapman pmachapman self-assigned this May 18, 2025
@pmachapman pmachapman force-pushed the lynx/sf-3370-improve-performance-for-large-projects branch from 2be5bb8 to b2209fd Compare May 18, 2025 21:34
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: This is a huge improvement - thank you!!!

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

@pmachapman pmachapman enabled auto-merge (squash) May 18, 2025 21:42
@pmachapman pmachapman merged commit 24d1b63 into master May 18, 2025
16 checks passed
@pmachapman pmachapman deleted the lynx/sf-3370-improve-performance-for-large-projects branch May 18, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants