Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: draw line to root deps when all explicit deps are root deps #8

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: draw line to root deps when all explicit deps are root deps #8

merged 1 commit into from
Jan 30, 2024

Conversation

onebytegone
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7715514072

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 32.792%
Totals Coverage Status
Change from base Build 7687173061: 0.6%
Covered Lines: 245
Relevant Lines: 658
💛 - Coveralls

@jthomerson
Copy link
Member

@onebytegone LGTM, but the tests failed a couple times. Assume that's just a fluke. With you to merge if you confirm

@onebytegone
Copy link
Collaborator Author

@jthomerson Yes, it's a race condition with coveralls. The next time we go to adjust the CI jobs, we should look into it.

@onebytegone onebytegone merged commit 69ce9aa into master Jan 30, 2024
7 of 10 checks passed
@onebytegone onebytegone deleted the draw-root-dep branch January 30, 2024 18:39
@MrMarCode
Copy link

LGTM as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrMarCode MrMarCode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onebytegone @coveralls @jthomerson @MrMarCode