Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node to 20.12.22 & grunt-contrib-uglify to 4.0.1 #177

Closed

Conversation

Timodie
Copy link

@Timodie Timodie commented Jun 26, 2024

Description

In a similar fashion to silvermine/videojs-airplay#54, this PR upgrades the repo node 20.12.22 and also upgrades "grunt-contrib-uglify to 5.2.2

@Timodie Timodie force-pushed the taddai/upgrade-node-20.12.22 branch from dad2a1f to bc0cbcb Compare June 27, 2024 19:34
@Timodie Timodie closed this Jul 1, 2024
@Timodie Timodie reopened this Jul 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 18.386%. remained the same
when pulling bc0cbcb on Timodie:taddai/upgrade-node-20.12.22
into 718c832 on silvermine:master.

@Timodie Timodie marked this pull request as draft August 1, 2024 22:55
@Timodie Timodie force-pushed the taddai/upgrade-node-20.12.22 branch from d720906 to c4eb96f Compare August 7, 2024 20:52
@coveralls
Copy link

coveralls commented Aug 7, 2024

Coverage Status

coverage: 18.386%. remained the same
when pulling 4cb0f48 on Timodie:taddai/upgrade-node-20.12.22
into 718c832 on silvermine:master.

@Timodie Timodie force-pushed the taddai/upgrade-node-20.12.22 branch from c4eb96f to 17d6c77 Compare August 7, 2024 21:05
Tim Addai added 6 commits August 7, 2024 17:09
Updates the .nvmrc to point node version 20.12.2
Creates the necessary scripts to support
commands that will be exeucted during the build
The [email protected] package would break because Babel no
longer removes `const` based on our configurations and how they interact
with the latest browserslist output.

However, [email protected] or later does not break when it sees
`const`. So, we can update to the latest version, 5.2.2.
This was necessary due to the update to
the version of grunt-contrib-uglify.
Uglify was configured to mangle/compress in
debug mode and beautify mode in
production.This should be reversed.
The CI steps need to be updated to use Node 20.
While doing so, we incorporated some additional work:
- Update all actions to use the latest versions that run on Node 20
- Update the test matrix to use our .nvmrc file as one of the Node
versions to test againsts
- Check for uncommitted changes after installing dependencies
@Timodie Timodie force-pushed the taddai/upgrade-node-20.12.22 branch from 17d6c77 to 4cb0f48 Compare August 7, 2024 21:28
@Timodie Timodie marked this pull request as ready for review August 7, 2024 21:31
@Timodie Timodie closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants