-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to node 20.12.22 & grunt-contrib-uglify to 5.2.2 #178
Changes from all commits
0aa9dd3
1173a79
ee5f2ad
4857168
89382b2
4cb0f48
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,34 +5,59 @@ on: [ push, pull_request ] | |
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
nvmrc: ${{ steps.makeNodeVersionOutput.outputs.nvmrc }} | ||
steps: | ||
- | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # Fetch all history | ||
- | ||
uses: actions/setup-node@v3 | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version-file: '.nvmrc' | ||
- run: npm i -g [email protected] | ||
- | ||
name: Put NVM version in output | ||
id: makeNodeVersionOutput | ||
run: echo "nvmrc=$(cat .nvmrc)" >> "$GITHUB_OUTPUT" | ||
|
||
- run: npm ci | ||
- run: npm run check-node-version | ||
- run: npm run standards | ||
- run: npm run build | ||
- | ||
name: Check for uncommitted changes # Done after dependency install and build to ensure code isn't compromised | ||
run: if [ -n "$(git status --porcelain)" ]; then echo 'There are uncommitted changes.'; exit 1; fi | ||
test: | ||
needs: [ build ] | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: [ 12, 14, 16, 'lts/*', 'latest' ] | ||
node-version: [ 16, '${{ needs.build.outputs.nvmrc }}', 'lts/*', 'latest' ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be on a new line below? |
||
with: | ||
fetch-depth: 0 # Fetch all history | ||
- | ||
name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm i -g [email protected] | ||
- run: npm ci # Reinstall the dependencies to ensure they install with the current version of node | ||
- run: npm test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we be running the following before
|
||
- name: Coveralls | ||
uses: coverallsapp/github-action@v1 | ||
- | ||
name: Coveralls | ||
uses: coverallsapp/github-action@v2 | ||
with: | ||
parallel: true | ||
flag-name: ${{ matrix.node-version }} | ||
finish: | ||
needs: [ test ] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- | ||
name: Close parallel build | ||
uses: coverallsapp/github-action@v2 | ||
with: | ||
parallel-finished: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
16.15.0 | ||
20.12.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we are standardizing on including the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this new line intended?