DEP Upgrade bootstrap and reactstrap #3050
Open
+39
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/6.0/upgrade-bootstrap
branch
from
e711a96 to
55733b8
Compare
GuySartorelli
force-pushed
the
pulls/6.0/upgrade-bootstrap
branch
from
55733b8 to
e2a78f3
Compare
GuySartorelli
commented
Jan 23, 2025
Comment on lines
-149
to
-161
| .input-group-append { | ||
| z-index: 2; | ||
|
|
||
| &:last-of-type { | ||
| z-index: 1; | ||
| } | ||
|
|
||
| .btn { | ||
| margin-top: 0; | ||
| padding-top: $input-padding-y; | ||
| padding-bottom: $input-padding-y; | ||
| } | ||
| } |
There was a problem hiding this comment.
https://getbootstrap.com/docs/5.0/migration/#forms
Dropped
.input-group-appendand.input-group-prepend. You can now just add buttons and .input-group-text as direct children of the input groups.
Turns out the styling isn't needed anymore in any case, from what I can tell, so just removed this block outright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1889 which links to the specific upgrade guide entries for most changes made.
Issue