Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #92

Merged
merged 1 commit into from
Oct 19, 2023
Merged

MNT Remove TODO comments #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions client/src/bundles/segment-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ window.jQuery.entwine('ss', ($) => {

redraw() {
const field = this.find(':text');
// @todo these aren't used, should they be? Otherwise, remove
// const value = field.val();

// let preview = value;

// if (value.length > this.getMaxPreviewLength()) {
// preview = this.getEllipsis()
// + value.substr(value.length - this.getMaxPreviewLength(), value.length);
// }

Copy link
Contributor Author

@sabina-talipova sabina-talipova Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented out block exists since 2017th and we didn't uncomment it. I think we don't need this anymore.

this.find('.preview').text(field.data('preview'));
},

Expand Down