Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #312

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions client/src/components/HistoryViewer/HistoryViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,6 @@ HistoryViewer.propTypes = {
}),
page: PropTypes.number,
schemaUrl: PropTypes.string,
// @todo replace this with import { VIEW_MODE_STATES } from 'state/viewMode/ViewModeStates'
// when webpack-config has this export available via silverstripe/admin
previewState: PropTypes.oneOf(['edit', 'preview', 'split']),
actions: PropTypes.object,
onSelect: PropTypes.func,
Expand Down
3 changes: 1 addition & 2 deletions client/src/components/HistoryViewer/HistoryViewer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ $diff-added-color: #b9f1c8;
}
}

// Todo: remove this when the CMS is React driven and we don't need this hack
.history-viewer__preview {
margin-top: -54px;
}
Expand All @@ -84,7 +83,7 @@ $diff-added-color: #b9f1c8;
}
}

// Hide preview on small devices. @todo replace this with a view toggle component
// Hide preview on small devices.
@include media-breakpoint-down(md) {
.history-viewer__preview {
display: none;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class HistoryViewerVersionDetail extends PureComponent {

/**
* Until the CMS is fully React driven, we must control certain aspects of the CMS DOM with
* manual CSS tweaks. @todo remove this when React drives the CMS.
* manual CSS tweaks.
*
* @param {boolean} add
*/
Expand Down Expand Up @@ -226,8 +226,6 @@ HistoryViewerVersionDetail.propTypes = {
}),
PropTypes.bool,
]),
// @todo replace this with import { VIEW_MODE_STATES } from 'state/viewMode/ViewModeStates'
// when webpack-config has this export available via silverstripe/admin
previewState: PropTypes.oneOf(['edit', 'preview', 'split']),
};

Expand Down