Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and update dependencies #414

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add tests and update dependencies #414

wants to merge 7 commits into from

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Feb 2, 2025

Enhance testing coverage with additional test cases and update the getrandom dependency to version 0.3 for improved compatibility with WebAssembly.

Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 28686c8

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.3±1.89µs 94.7±3.01µs +2.60%
canada/simd_json::to_tape_with_buffers 3.3±0.15ms 3.4±0.14ms +3.03%
citm_catalog/simd_json::to_tape_with_buffers 1049.3±73.56µs 1065.5±74.46µs +1.54%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.20µs 3.8±0.20µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.5±0.96µs 41.3±0.92µs +1.98%
log/simd_json::to_tape_with_buffers 1573.3±93.84ns 1571.2±80.75ns -0.13%
twitter/simd_json::to_tape_with_buffers 419.9±27.33µs 430.0±25.07µs +2.41%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for afb1cfc

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.9±1.38µs 92.5±3.26µs +0.65%
canada/simd_json::to_tape_with_buffers 3.3±0.16ms 3.3±0.14ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1053.3±71.74µs 1050.5±70.17µs -0.27%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.20µs 3.7±0.21µs -2.63%
github_events/simd_json::to_tape_with_buffers 40.4±0.93µs 40.4±0.84µs 0.00%
log/simd_json::to_tape_with_buffers 1565.5±87.14ns 1564.9±87.68ns -0.04%
twitter/simd_json::to_tape_with_buffers 422.2±24.93µs 420.7±26.42µs -0.36%

Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 9d5197f

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.4±1.77µs 92.1±3.79µs -1.39%
canada/simd_json::to_tape_with_buffers 3.3±0.14ms 3.3±0.14ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1055.3±74.46µs 1060.5±80.41µs +0.49%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.25µs 3.7±0.27µs -2.63%
github_events/simd_json::to_tape_with_buffers 40.6±0.99µs 40.8±1.71µs +0.49%
log/simd_json::to_tape_with_buffers 1573.2±89.15ns 1604.7±93.37ns +2.00%
twitter/simd_json::to_tape_with_buffers 423.4±27.52µs 422.4±27.67µs -0.24%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 0f82034

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.7±1.38µs 91.3±2.62µs -2.56%
canada/simd_json::to_tape_with_buffers 3.3±0.13ms 3.3±0.10ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1062.9±74.70µs 1054.0±76.98µs -0.84%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.18µs 3.7±0.28µs 0.00%
github_events/simd_json::to_tape_with_buffers 41.1±0.82µs 40.3±1.56µs -1.95%
log/simd_json::to_tape_with_buffers 1598.2±88.72ns 1583.5±89.42ns -0.92%
twitter/simd_json::to_tape_with_buffers 428.4±26.50µs 421.5±26.92µs -1.61%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for a4dc729

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 97.1±1.76µs 94.5±3.48µs -2.68%
canada/simd_json::to_tape_with_buffers 3.4±0.17ms 3.3±0.18ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1088.9±78.58µs 1076.9±78.18µs -1.10%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 4.0±0.23µs 4.0±0.34µs 0.00%
github_events/simd_json::to_tape_with_buffers 42.8±1.39µs 42.2±1.91µs -1.40%
log/simd_json::to_tape_with_buffers 1652.4±111.89ns 1628.2±125.93ns -1.46%
twitter/simd_json::to_tape_with_buffers 435.5±28.08µs 434.0±30.20µs -0.34%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 00cfe5c

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 94.6±1.59µs 93.7±3.39µs -0.95%
canada/simd_json::to_tape_with_buffers 3.4±0.17ms 3.3±0.14ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1071.2±71.84µs 1076.6±77.43µs +0.50%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.19µs 3.7±0.27µs -2.63%
github_events/simd_json::to_tape_with_buffers 41.6±0.92µs 41.3±1.59µs -0.72%
log/simd_json::to_tape_with_buffers 1605.8±94.77ns 1631.7±98.20ns +1.61%
twitter/simd_json::to_tape_with_buffers 431.0±28.83µs 431.7±27.18µs +0.16%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 19b92a5

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 94.5±1.39µs 92.5±3.14µs -2.12%
canada/simd_json::to_tape_with_buffers 3.4±0.17ms 3.3±0.15ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1067.4±72.94µs 1062.8±69.39µs -0.43%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.19µs 3.7±0.28µs -2.63%
github_events/simd_json::to_tape_with_buffers 41.4±0.96µs 40.6±1.56µs -1.93%
log/simd_json::to_tape_with_buffers 1764.1±88.48ns 1601.8±101.87ns -9.20%
twitter/simd_json::to_tape_with_buffers 430.3±25.88µs 427.5±27.67µs -0.65%

@Licenser Licenser force-pushed the updates-and-tests branch 2 times, most recently from 117c908 to 458dc4d Compare February 2, 2025 19:31
Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 6e4b9b1

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.1±1.11µs 90.9±2.48µs -2.36%
canada/simd_json::to_tape_with_buffers 3.3±0.09ms 3.3±0.13ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1049.8±66.51µs 1035.5±64.93µs -1.36%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.6±0.15µs 3.6±0.21µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.9±0.73µs 39.8±1.27µs -2.69%
log/simd_json::to_tape_with_buffers 1596.4±72.15ns 1577.9±87.75ns -1.16%
twitter/simd_json::to_tape_with_buffers 422.0±24.05µs 418.2±24.60µs -0.90%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 58a8ba0

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.6±1.83µs 93.1±3.58µs -0.53%
canada/simd_json::to_tape_with_buffers 3.4±0.18ms 3.3±0.19ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1066.6±75.59µs 1064.1±77.21µs -0.23%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.9±0.30µs 3.8±0.32µs -2.56%
github_events/simd_json::to_tape_with_buffers 41.8±1.38µs 41.8±1.71µs 0.00%
log/simd_json::to_tape_with_buffers 1596.4±107.71ns 1563.8±98.40ns -2.04%
twitter/simd_json::to_tape_with_buffers 427.9±29.77µs 428.1±29.76µs +0.05%

Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 558bbb4

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.7±1.34µs 90.4±2.78µs -1.42%
canada/simd_json::to_tape_with_buffers 3.3±0.12ms 3.3±0.17ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1049.3±70.30µs 1051.0±68.30µs +0.16%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.17µs 3.6±0.26µs -2.70%
github_events/simd_json::to_tape_with_buffers 40.1±0.79µs 40.0±1.38µs -0.25%
log/simd_json::to_tape_with_buffers 1566.6±79.12ns 1584.6±80.92ns +1.15%
twitter/simd_json::to_tape_with_buffers 419.1±26.53µs 420.6±26.84µs +0.36%

Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 44.21053% with 53 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (8a9169b) to head (295496e).
Report is 205 commits behind head on main.

Files with missing lines Patch % Lines
src/value/tape/cmp.rs 0.00% 16 Missing ⚠️
src/value/lazy/cmp.rs 6.25% 15 Missing ⚠️
src/serde/value/borrowed/de.rs 0.00% 4 Missing ⚠️
src/serde/value/owned/de.rs 0.00% 4 Missing ⚠️
src/value/tape/trait_impls.rs 0.00% 4 Missing ⚠️
src/lib.rs 50.00% 2 Missing ⚠️
src/value/borrowed/cmp.rs 88.23% 2 Missing ⚠️
src/value/borrowed/serialize.rs 50.00% 2 Missing ⚠️
src/value/owned/cmp.rs 88.23% 2 Missing ⚠️
src/value/owned/serialize.rs 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8a9169b) and HEAD (295496e). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (8a9169b) HEAD (295496e)
128bit 2 0
3 0
beef 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   81.83%   72.16%   -9.67%     
==========================================
  Files          32       50      +18     
  Lines        9992    12280    +2288     
==========================================
+ Hits         8177     8862     +685     
- Misses       1815     3418    +1603     
Flag Coverage Δ
?
128bit ?
beef ?
unittests 72.16% <44.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 4e662c5

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 95.1±1.76µs 93.8±1.61µs -1.37%
canada/simd_json::to_tape_with_buffers 3.4±0.16ms 3.3±0.16ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1084.6±77.37µs 1066.4±79.81µs -1.68%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.21µs 3.8±0.22µs 0.00%
github_events/simd_json::to_tape_with_buffers 41.8±0.92µs 41.4±1.44µs -0.96%
log/simd_json::to_tape_with_buffers 1619.1±100.55ns 1598.1±103.32ns -1.30%
twitter/simd_json::to_tape_with_buffers 434.1±29.01µs 428.5±30.35µs -1.29%

Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

Benchmark for 3df2d1c

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.6±2.71µs 91.0±3.34µs -1.73%
canada/simd_json::to_tape_with_buffers 3.3±0.14ms 3.3±0.13ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1047.9±68.46µs 1047.5±70.97µs -0.04%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.20µs 3.7±0.20µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.8±1.04µs 40.1±0.86µs -1.72%
log/simd_json::to_tape_with_buffers 1568.5±86.18ns 1563.0±88.61ns -0.35%
twitter/simd_json::to_tape_with_buffers 419.9±25.69µs 418.7±25.73µs -0.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant