Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

General cleanup #18

wants to merge 6 commits into from

Conversation

galengidman
Copy link

Deleted a bunch of unnecessary leftover files and code from TwentyTen. Also made minor changes such as adding wp_head(); and wp_footer();, calling jQuery correctly, changing the footer to a <footer> tag, and making pages display just like posts by default.

@simplebits
Copy link
Owner

Thanks, Galen! I need to pull this down and check everything out, but the massive cleanup from the twentyten code is much appreciated :)

One note on the footer element: I purposefully didn't use it to avoid styling it from any of the patterns. Then again, I DID use nav, so maybe it's avoidable by namespacing with classes, etc.

The formatting of the .less file is my own preference, but perhaps closing brackets flush left would be more universally liked.

Would be great to get feedback on this pull request from others as well.

Thanks again!

@galengidman
Copy link
Author

Good point on the <footer> tag, Dan. What if you were to use this plugin (https://github.com/thingsinjars/jQuery-Scoped-CSS-plugin) to scope the <style> blocks that style the patterns? That would allow you to use any tag you wanted in the theme and ensure that your pattern styles didn't bleed over to the theme.

On the .less formatting, yeah, I though it was a little annoying and fixed it for myself, but whatever works for me.

@galengidman
Copy link
Author

Dan: Went ahead and scoped the pattern styles to the preview. Lemme know what you think.

@franz-josef-kaiser
Copy link

@galengidman Did this work for you? Doesn't work too good for me (with some other theme) at the moment. It seems to be pulling other styles than the ones from get_post_meta( 'css' );.

@franz-josef-kaiser
Copy link

@galengidman Some further notes after forking and testing your version: The scoped plugin successfully prevents the use of any (remote?-)images. You also got missing quotes in the sidebar.php file. title and ASC are currently set as (non existant) constants.

@drooog
Copy link

drooog commented Mar 4, 2013

Does this plan to get merged?

@galengidman
Copy link
Author

I don't believe so — I think Dan got busy. Who knows though — we may revisit it in the future.

@drooog
Copy link

drooog commented Mar 6, 2013

Right. Pretty quiet here... pity.. its a great resource and some valuable additions have been made in the last year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants