Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog v1.1 #69

Open
7 of 8 tasks
filipswit opened this issue Nov 15, 2022 · 25 comments
Open
7 of 8 tasks

changelog v1.1 #69

filipswit opened this issue Nov 15, 2022 · 25 comments

Comments

@filipswit
Copy link
Collaborator

filipswit commented Nov 15, 2022

edit

@gkasprow
Copy link
Member

@filipswit did you consult moving the EEPROMs to separate I2C interface with software guys?

@filipswit
Copy link
Collaborator Author

no, but default EEPROM, IC5 is not moved.
We can't add aditional footprint - sinara-hw/Kasli#97, because of conflict with SFP3 addres, so I made same solution as in Kasli v2.0.2

@kaolpr
Copy link
Member

kaolpr commented Nov 23, 2022

I believe there was some discussion on version naming convention and patch number (according to ..) was to be reserved only for compatible component replacements. Here I can see some issue fixes.

If such discussion was not written (honestly, don't remember) maybe we should write down rules on that.

@filipswit
Copy link
Collaborator Author

@gkasprow and @kaolpr so should I rename it to v1.1?

@gkasprow
Copy link
Member

yes, since it requires software changes, there must be new revision

@gkasprow
Copy link
Member

The R110 and R100 could be replaced with E24 values
image

@kaolpr
Copy link
Member

kaolpr commented Nov 23, 2022

yes, since it requires software changes, there must be new revision

@gkasprow How does it require software changes? IO expander has different address / registry map?

@gkasprow
Copy link
Member

I2C EEPROM is connected in a different way

@gkasprow
Copy link
Member

Before EEPROM was connected to shared bus, now it has a dedicated FPGA pins.

@gkasprow
Copy link
Member

old-style regulators may not like 10uF at the output. I'd replace C376 with a 100nF capacitor and decouple it from LDOs 1uF caps with a few tens Ohm resistor. With a low ESR multi-uF load, it may oscillate.

@gkasprow
Copy link
Member

@filipswit there is yet another issue that needs correction
The MCP23017 expander port 7 must be output. So we need to swap DISABLE with FAULT
I'd add a reistors for revision ID like in Kasli + one resistor for variant ID (a kind of expanders assembled) placed on the same sheet as I2C expanders

@filipswit
Copy link
Collaborator Author

filipswit commented Nov 23, 2022

decouple it from LDOs 1uF caps with a few tens Ohm resistor

You mean to place resistor (22R?) in series with 1uF at all LDOs Vbias inputs?
BTW. I can place any different LDO if you have any other cheap and small.

The MCP23017 expander port 7 must be output. So we need to swap DISABLE with FAULT

image

So it looks that IC24 is fine (these are test points) and in IC25 I should swap 'VUSB_PRESENT_N', with 'SFP_0.LED'?
image

I'd` add a reistors for revision ID like in Kasli + one resistor for variant ID (a kind of expanders assembled) placed on the same sheet as I2C expanders

I'll try to fit 3-4 rev ID bits and one variant ID resistor

@gkasprow
Copy link
Member

decouple it from LDOs 1uF caps with a few tens Ohm resistor

You mean to place resistor (22R?) in series with 1uF at all LDOs Vbias inputs? BTW. I can place any different LDO if you have any other cheap and small.

just add a single 22Ohm (or similar already in the BOM) at the LDO output after the 100nF cap.

@gkasprow
Copy link
Member

So it looks that IC24 is fine (these are test points) and in IC25 I should swap 'VUSB_PRESENT_N', with 'SFP_0.LED'?

yep, my bad

@filipswit
Copy link
Collaborator Author

Just verified the DS for this LDO, so it looks 470nF is absolute minimum i this case:
image

Would it be good enough solution?
image

@gkasprow
Copy link
Member

OK, so you found better DS than me :)

@gkasprow
Copy link
Member

No need for series resistor then.

@filipswit filipswit changed the title changelog v1.0.2 changelog v1.1 Nov 24, 2022
@filipswit
Copy link
Collaborator Author

@gkasprow could you please look at the changes one more time?

@kaolpr
Copy link
Member

kaolpr commented Dec 27, 2022

@gkasprow @filipswit Can we assume v1.1 is reviewed?

@kaolpr
Copy link
Member

kaolpr commented Dec 27, 2022

@gkasprow Do you think sinara-hw/Kasli#99 should be implemneted here?

@gkasprow
Copy link
Member

SOT-23 version of EEPROM is still not available

@gkasprow
Copy link
Member

please add note close to the I2C expanders that ASSY variant need to be updated.

@gkasprow
Copy link
Member

why both EEPROMs are not mounted?
image

@gkasprow
Copy link
Member

Ah, I see, IC5 is connected instead...
I'd add 24AA025E48T-I/OT assembly variant to it as well.

@filipswit
Copy link
Collaborator Author

yeep, it should be added. I've made issue to not forget about it in next revision #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants