-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make notifications stay in the Notification Center on macOS #504
Conversation
It's not clear why you have reimplemented notifications in the main process. Can you explain your changes? |
The messenger.com use the HTML5 Notification API. I guess this differs from Electron Notification because the notification does not stay in the Notification Center. |
I think you missed by suggested solution there though:
|
Ok. Thank you. |
@janosorcsik Is this ready to be reviewed? |
@sindresorhus Yes, it is. |
87cbb3b
to
0cb95de
Compare
…into notification * 'notification' of https://github.com/janosorcsik/caprine: Catch notification in the renderer and send to the main process Fix lint errors Notifications don't show up in the Notification Center on macOS #317
This works well. Nice work! And sorry for the delay. |
Would you be able to add a click action to the notification so when it's clicked it opens the correct conversation? |
@sindresorhus Everything is done :) |
.vscode/launch.json
Outdated
@@ -0,0 +1,30 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add unrelated files.
Really nice work on this, @janosorcsik 🎉 |
Fixes sindresorhus#593 Related to sindresorhus#504
Fixes #317