Start to add generation 9 Pokemon #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, letting a blank line will be a problem, because of the getId function ... but I think adding a false line is not a solution ... |
|
Hi @sindresorhus 👋 Could we try to move forward with this? Is there anything that you need help with? |
data/de.json
Outdated
| @@ -1,907 +1,1012 @@ | |||
| [ | |||
| "Bisasam", | |||
There was a problem hiding this comment.
Don't change the indentation.
|
You need to add all the data for this to be mergable. |
|
Hi @sindresorhus . I just updated the files ( using tabs + adding pokemon ) . Also, it seems that some orders has changed ... So, here are my sources : |
data/de.json
Outdated
| "Eisenfels", | ||
| "Eisenhaupt", | ||
| "Terapagos", | ||
| "Infamomo" |
There was a problem hiding this comment.
sorry ... I redo a check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I start to add gen 9 .
I only add the names I found ( I found Korean but seems to use a different order ) .
Also, 980 and 987 seems missing from lists, so I let a blank line .
Don't hesitate to add names (or correct), I will update the PR with them