WebKit deprecated request in favour of enter

[mihar-22]

WebKit has deprecated webkitRequestFullscreen in favour of webkitEnterFullscreen.

Ref: #139

https://developer.apple.com/documentation/webkitjs/htmlvideoelement/1630649-webkitenterfullscreen?language=javascript

https://developer.apple.com/documentation/webkitjs/htmlvideoelement/1633500-webkitenterfullscreen?language=javascript

[RusinovAnton]

Maybe it makes sense to leave the old one for older browsers to happen?

[RusinovAnton]

This won't work as the webkitEnterFullscreen only present in the HTMLVideoElement object, not in the document. There should be a way to check whether video object has ability to enter fullscreen.

[mihar-22]

Ye you're right @RusinovAnton, not sure how I missed that. It seems like you can't request fullscreen on the document in Safari? I just tried and nothing worked. Has it always been like this?

[RusinovAnton]

I couldn't find actual info on that. I can see that there is no webkitEnterFullscreen property on document object in Safari. However. there is a document.documentElement.webkitRequestFullscreen which seems like not working for me. I've tried to find maybe there are some feature flags I can enable, but couldn't find any.

[RusinovAnton]

Uh-oh, it actually works if its triggered not from the console but from the user input even, like button click! -

button.addEventListener('click', ()=> document.documentElement.webkitRequestFullscreen())

[RusinovAnton]

There is no document.documentElement.webkitEnterFullscreen property, tho

and the doc on it is pretty much empty :(

https://developer.apple.com/documentation/tvmljs/document/1630671-documentelement