Use should_sync_field from singer #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterati
force-pushed
the
feature/use-should-sync-field
branch
from
bf8c73a to
7808fbb
Compare
moonlance
pushed a commit
to moonlance/tap-db2
that referenced
this pull request
May 10, 2022
* Current_log_version to None on full sync * Update current_log_instance to None on full sync * removed unwanted space * test * working * formatting reverted * Added logic to factor in None values for self.current_log_version * Update current_log_version to be min_valid_version if full sync * moved the current_log_version = min_valid_version to the if statement above so that it only changes if current_log_version is actually None * added comment * changed to _get_current_log_version for current_log_version * push for testing * logging * logger 2 * more logging * updated logger * fixed logger * one more logging change * one more * New log_based_initial_full_table function * fixed none type again * get current version back * removed logging from init.py * One more change to loook at Nones * removed logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires updated singer-python (pending PR: singer-io/singer-python#79)