Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integer as valid type to groups #41

Closed
wants to merge 1 commit into from

Conversation

michael-boehm
Copy link
Contributor

@michael-boehm michael-boehm commented May 26, 2021

Description of change

  • add integer as valid type to groups
  • fixes Error integrating group table #37
  • reason: The field auto_ticket_assign takes on boolean AND integer values (example from the API: "auto_ticket_assign":false or "auto_ticket_assign":2), because Freshdesk uses a checkbox AND radio buttons for it, see here.

Manual QA steps

  • none

Risks

  • should be none(?)

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @michael-boehm, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @michael-boehm!

Thank you for signing the Singer Contribution License Agreement.

@cosimon
Copy link
Contributor

cosimon commented May 28, 2021

This has been merged as part of #42. There is a subtle potential bug in this schema change where a record with an auto_ticket_assign value of 0 could be coerced to false because boolean is listed first in the schema. #42 swapped the ordering so that should not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error integrating group table
3 participants