TDL-20359 Add custom exception handling. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Verify that `time.sleep` was called for 'Retry-After' seconds from the header. | ||
| mock_sleep.assert_any_call(int(retry_seconds)) | ||
|
|
||
| def test_rate_limite_not_exceeded(self, mock_sleep, mock_request): |
There was a problem hiding this comment.
Suggested change
| def test_rate_limite_not_exceeded(self, mock_sleep, mock_request): | |
| def test_rate_limit_not_exceeded(self, mock_sleep, mock_request): |
tap_freshdesk/client.py
Outdated
| @@ -7,7 +7,110 @@ | |||
|
|
|||
| LOGGER = singer.get_logger() | |||
| BASE_URL = "https://{}.freshdesk.com" | |||
| DEFAULT_TIMEOUT = 300 | |||
There was a problem hiding this comment.
Suggested change
| DEFAULT_TIMEOUT = 300 | |
| REQUEST_TIMEOUT = 300 |
tap_freshdesk/client.py
Outdated
| Set timeout value from config, if the value is passed. | ||
| Else raise an exception. | ||
| """ | ||
| timeout = self.config.get("timeout", DEFAULT_TIMEOUT) |
There was a problem hiding this comment.
Suggested change
| timeout = self.config.get("timeout", DEFAULT_TIMEOUT) | |
| timeout = self.config.get("request_timeout", DEFAULT_TIMEOUT) |
tap_freshdesk/client.py
Outdated
| Set timeout value from config, if the value is passed. | ||
| Else raise an exception. | ||
| """ | ||
| timeout = self.config.get("timeout", DEFAULT_TIMEOUT) |
There was a problem hiding this comment.
Add detail about request_timeout in the README file.
There was a problem hiding this comment.
Added detail about request_timeout in the README file.
…L-20359-add-custom-exception-handling
dbshah1212
reviewed
Aug 25, 2022
tap_freshdesk/client.py
Outdated
| }, | ||
| 403: { | ||
| "raise_exception": FreshdeskAccessDeniedError, | ||
| "message": "The agent whose credentials were used in making this request was not authorized to perform this API call." |
There was a problem hiding this comment.
Suggested change
| "message": "The agent whose credentials were used in making this request was not authorized to perform this API call." | |
| "message": "The agent whose credentials were used to make this request was not authorized to perform this API call." |
dbshah1212
reviewed
Aug 25, 2022
tap_freshdesk/streams.py
Outdated
| # Skipping 404 error as it is returned for deleted tickets and spam | ||
| LOGGER.warning("Could not retrieve time entries for ticket id {}. This may be caused by tickets " | ||
| "marked as spam or deleted.".format(self.parent_id)) | ||
| pass |
dbshah1212
reviewed
Aug 25, 2022
| (409, "AInconsistent/Conflicting State", client.FreshdeskConflictingStateError), | ||
| (415, "Unsupported Content-type", client.FreshdeskUnsupportedContentError), | ||
| (429, "Rate Limit Exceeded", client.FreshdeskRateLimitError), | ||
| (500, "Unexpected Server Error", client.FreshdeskServerError), |
There was a problem hiding this comment.
Take one unexpected error as well like 503 or 505
There was a problem hiding this comment.
Added test case to verify 503 status code.
…L-20359-add-custom-exception-handling
dbshah1212
reviewed
Sep 2, 2022
tap_freshdesk/client.py
Outdated
| 500: { | ||
| "raise_exception": FreshdeskServerError, | ||
| "message": "Unexpected Server Error." | ||
| }, |
dbshah1212
reviewed
Sep 2, 2022
| """ | ||
| Retrieve the error code and the error message from the response and return custom exceptions accordingly. | ||
| """ | ||
| try: |
There was a problem hiding this comment.
Why do we need this? We can call this function if status_code is not equal to 200
There was a problem hiding this comment.
Agree @dbshah1212. Removed try-except and raising error directly if status_code is not equal to 200.
dbshah1212
approved these changes
Sep 8, 2022
savan-chovatiya
approved these changes
Sep 8, 2022
…L-20359-add-custom-exception-handling
sgandhi1311
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
5xx errors,TimeoutErrorandConnnectionError.time_entriesstream.Manual QA steps
Risks
Rollback steps