-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tdl 20357 add missing tap tester tests #53
Open
NevilParikh14
wants to merge
25
commits into
crest-master
Choose a base branch
from
TDL-20357-add-missing-tap-tester-tests
base: crest-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
25aabda
initial commit
NevilParikh14 3beaf78
Updated test cases
NevilParikh14 4d98589
added contacts stream in base.py
NevilParikh14 55e9e53
updated bookmark test cases
NevilParikh14 378ad79
Removed unused line
NevilParikh14 2286d1f
updated bookmark with filter param test case
NevilParikh14 e1aafd9
updated all fileds test case
NevilParikh14 ba6395b
Updated to LOGGER from print
NevilParikh14 010217d
Updated assertion message
NevilParikh14 f2313b8
added back commented print statement
NevilParikh14 5fc93e0
resolved review comments
NevilParikh14 3ecf64b
Updated pagination test case
NevilParikh14 5c3ccd5
uncommented LOGGERS
NevilParikh14 0c1ba1f
resolved review comments
NevilParikh14 f8202ef
removed unused imports
NevilParikh14 76be7cc
resolved review comments
NevilParikh14 6dc4ee8
resolved review comments
NevilParikh14 73afe0c
updated param name of expected_streams
NevilParikh14 35e3d16
removed unused import
NevilParikh14 422ec12
added tap-tester test for parent-child syncing
NevilParikh14 957e4b9
updated parent-child sync file
NevilParikh14 33180fb
updated pagination test case
NevilParikh14 2d777e5
updated bookmark with filter param test
NevilParikh14 013772e
resolved review comments
NevilParikh14 a215fb0
resolved review comments
NevilParikh14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated comment as per suggestion.