[TDL-25626] Fix integration test failures #72
Conversation
|
Have you verified whether the data is truly unavailable by retroactively examining the start_date for all the untestable streams? |
After checking records dating back to 2010 for the start date, no data was found. Consequently, the pertinent streams are being labeled as untestable. |
tests/test_intercom_bookmarks.py
Outdated
| @@ -51,6 +63,22 @@ def calculated_states_by_stream(self, current_state): | |||
| return stream_to_calculated_state | |||
|
|
|||
| def test_run(self): | |||
| # Created card for untestable/unstable streams. | |||
| # FIX CARD: https://jira.talendforge.org/browse/TDL-17035 | |||
| # The stream: "conversation_parts" is child stream and bookmark is being written of parent stream. Thus, skipping the stream | |||
There was a problem hiding this comment.
I think we are writing the bookmarks for the child over here -
tap-intercom/tap_intercom/streams.py
Line 121 in 9edf65f
Can you please verify once?
There was a problem hiding this comment.
Since child streams use the bookmark set by parents stream, thus we don't need to test child stream bookmarking.
I'll update the comment in the code to reflect the same message.
Description of change
Manual QA steps
Risks
Rollback steps