Fix conversations stream bookmarking #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…singer-io/tap-intercom into TDL-25075-fix-bookmarking-conversations
RushiT0122
changed the title
…singer-io/tap-intercom into TDL-25075-fix-bookmarking-conversations
sgandhi1311
reviewed
May 6, 2024
| "sort": { | ||
| "field": self.replication_key, | ||
| "field": "id", |
There was a problem hiding this comment.
field is hardcoded to id, is it working for all the streams?
There was a problem hiding this comment.
This is just for the Conversations stream.
|
Are we writing the bookmarks for the child streams? |
Yes (streams.py#L121) |
sgandhi1311
approved these changes
May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
conversationsrecords updated after previous sync start were missed in next sync because we were setting last sync end time as bookmark. Fixed this issue by bookmarking last sync start time.search_queryto resume sync from the last processedconversationsrecord.Manual QA steps
Risks
Rollback steps