Tdl 15987 all non pk changes #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bug fix for full table stream record count * updated config.yml file * added comment Co-authored-by: harshpatel4_crest <[email protected]>
* big fix for start date of child streams * updated test name * updated the code to fix bug in visitor history * added dev and test env * updated config.yml file, resolved review comments Co-authored-by: harshpatel4_crest <[email protected]>
* added best practices * bug fix * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR Co-authored-by: harshpatel4_crest <[email protected]>
* added backoff for error and timout for requests * added dev and test env * run unittests in CCi * created a variable for timeout seconds * added comments and updated the code to use param from config for timeout * updated the code and added test cases * added comment, updated readme file * typecasted request timeout, updated unittest name * added code change for empty string timeout value from config * updated timeout code and added unittests * resolved pylint error * resolve unittest failure Co-authored-by: harshpatel4_crest <[email protected]>
* removed the endpoints dictionary * Removed an unwanted comment * added best practices * bug fix * TDL-14795: Removed unused imports * TDL-14795: Undo extra line changes * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * removed unused variable method * added unittest case for the updated code * resolved pylint errors * resolved pylint errors * resolved pylint errors * Removed f-string * resolved comments * added code coverage * fixec cirlceci error * resolved merge conflict * resolved removed conflict Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>
* removed the endpoints dictionary * Removed an unwanted comment * added best practices * bug fix * TDL-14795: Removed unused imports * TDL-14795: Undo extra line changes * TDL-6877 added backogg for conn reset error * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * TDL-6877 resolved the comments * resolved pylint errors * resolved pylint errors * Removed f-string * added code coverage in circleci * removed unwanted imports * fixed unittest error Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>
* updated incremental streams as full table * added a comment for code change * added dev and test env * run unittests in CCi * resolve test case failure * updated start date in test_sync * updated comment * added comment Co-authored-by: harshpatel4_crest <[email protected]>
* TDL-14950 removed the line that caused the bug and addd a unittest * added best practices * bug fix * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * resolved the comment and updated the testcase * removed commented code * Removed f-string from added code * added code coverage in circleci * added code comments Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>
* TDL-14964: Fixed noneType date parsing * Resolve pylint failure * Added nose in setup * Added code comments * Added code comments * Resolve pylint error * Resolved review comment and add coverage report in CircleCI * Added bookmark check in all unit tests * Revert some code as it is as covered in other PR Co-authored-by: savan-chovatiya <[email protected]>
* TDL-14945: Fixed iterator by making list * Updated comment message * TDL-14945: Updated setup file for resolve CircleCI build * Added code comments * Reolved review comment and add code coverage report in CircleCI Co-authored-by: savan-chovatiya <[email protected]>
* Added new tep-tester test cases * Updated all_fields test case for track_events stream * updated dev and test dependency for circleci * Updated start_date and added lookback_window assertion in bookmark test. * Updated all_fields and automatic_fields test cases as per review comments * Updated as per review comments * revert back replicatio key change * Added back config file * Commented some part of code * Updated circleci config file * Removed f-string * Changes updated * updated base file and bookmark test * Updated bookmark test Co-authored-by: savan-chovatiya <[email protected]>
* Added code comments * Removed trailing whitespaces * Updated comments as per suggestion * Updated setup.py to resolve CircleCI build failure * Added more comments as per review comments * Resolved pylint failure * Updating message to provide more information Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: Karan Panchal <[email protected]>
luandy64
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps