Tdl 13964 improve quickbooks reliability #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TDL-13967: Added ProfitAndLoss report stream * TDL-13967: Handled state updation if no records found * Added comments in unittests * Updated sync function for report streams * Fixed integration tests * Added stream into readme * Break down report parser for rows and columns * Resolved circleci failure * Updated date retrival from datetime object * Break down dev and test ddependancy in setup * TDL-13967: Resolved review comments * TDL-13967: Added code comments Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: Kyle Allan <[email protected]>
* TDL-13966: Updated Custom fields schema * TDL-13966: Updated sync tests to verify custom fields are available or not. * TDL-13966 : Updated test cases * Updated discovery test * Update dependancy Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: Kyle Allan <[email protected]>
KrisPersonal
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Code of PRs:
Manual QA steps
Risks
Rollback steps