Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query params #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

nschairer
Copy link

@nschairer nschairer commented Dec 2, 2021

Description of change

Added support to include arbitrary query parameters for any resource's web requests. Query parameters must be included in the json catalog at the level of "selected" under the key "query" as key value pairs in a json object.

Example:

"metadata": [
                {
                    "breadcrumb": [],
                    "metadata": {
                        "table-key-properties": [
                            "id"
                        ],
                        "forced-replication-method": "INCREMENTAL",
                        "valid-replication-keys": [
                            "created"
                        ],
                        "selected": true,
                        "query": {
                            "status": "all"
                        }
                    }
                },
               ...
]

Manual QA steps

Validated that the tap still runs in our dev environment with and without query parameters.

Risks

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant