Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miro code #136

Closed
wants to merge 27 commits into from
Closed

Miro code #136

wants to merge 27 commits into from

Conversation

prijendev
Copy link
Contributor

@prijendev prijendev commented Mar 16, 2022 •
edited
Loading

Description of change

Note

  • For some fields of streams, the normalization by rule_map was not tested due to the unavailability of data for that particular field.
  • We are not sure of the impact of adding the child breadcrumb on the UI side.
  • The rule map will not be applied for the fields which will be coming as a part of an empty object.
  • There will be multiple metadata breadcrumbs for the fields having anyOf usage.

Manual QA steps

Risks

Rollback steps

  • revert this branch

savan-chovatiya and others added 27 commits February 10, 2022 11:17
@savan-chovatiya @prijendev @namrata270998
TDL-14058: Update SDK and api version (#105)
994fcfd 
* Updated SDK and API version

* Added expand parameter for more streams

* Updated replication key for invoices

* added backward compability for invoice bookmark

* Added unit test and code coverage report in circleci

* Resolved unit test failure

* Updated stripe SDK to latest version

* Running all test for testing

* updated stripe version in config.yml

* Running all test for testing

* Running all test for testing

* Running all test for testing

* Updated base class of tap_tester to handle replication key change of invoices

* Reverted back config.yml to run dependant tests

* Reverted back config.yml to run dependant tests

* Updated all_field test case

* Added back payout stream

* Added comments in test case

* Fixed key in bookmark for invoice_line_items

* Fixed key in bookmark for invoice_line_items in get_bookmark

* Fixed charge stream for all_field test case

* Fixed payouts stream for all_field test case

* Updated amount value

* Resolved circleci error

* Fiexed all_field test case�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[�[�[3~�[�[C�[�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[xed invoice_line_item failure in all_field test case

* Fix the build_daily workflow definition

* Resolved review comment

* Updated all_field test case

* Updated test case for customer and invoice_line_item stream

* Updated util.py

* Removed fields from missing fields

* fixed subscription_items stream

* Resolved review comment and added function for get and write bookmark

* Updated code comment

* Tdl 5894 update invoices stream (#115)

* initial commit

* added back for all streams

* resolved comments

* fixed cci errors

* fixed typo in comment

* updated comment

* fixed typo in function

* fixed failures

* fixed error

* resolved failure for discount

* updated discount schema

* added bugtracker

* Tdl 6026 Modify 'customer' stream on 'test_all_fields.py' to pass (#109)

* Initial commit

* Updated util.py �[D�[D�[D�[D�[D�[D�[D�[DAPI version to latest in util.py

* Added support of tax_ids field

* Updated discount schema

* Updated datatype of percent_off field.

* Tdl 6597 Modify 'product' stream on 'test_all_fields.py' to pass (#108)

* Initial commit

* Added back schema_keys

* Uncommented expected assertion

* Removed skus field from schema

* TDL-6587 Modify 'invoice_line_items' stream on 'test_all_fields.py' to pass (#112)

* Initial commit

* Updated schema file

* Removed price field from schema

* Removed tax_rates from schema

* Removed extra fields from schema

* Updated schema file

* Added metadata in schema

* Added invoice_line_items in KNOWN_FAILING_FIELDS

* Updated price value�[D�[D�[D�[D�[Drecord value

* Updated all_field test case

* Merged changes

* Uncommented code

* Updated code comment

* TDL-5992 modify subscription items stream (#114)

* initial commit with subscription_items stream

* reverted back to all streams

* resolved pylint

* testing for subscription_items only

* resolved error

* added back for all streams

* resolved cci errors

* added commnets

* added automatic fields for subscription items

* removed updated from the schema

* removed empty line and updated base

* resolved comments

* chahnged updated

* reverted changes

* reverted changes

* removed updated from subscription_items

* reverted a type change

Co-authored-by: prijendev <[email protected]>

* TDL-17429 Revert back tiers field datatype conversion (#117)

* Initial commit for dict to stripe object conversion

* Resolved pylint error

* Updated test cases

* Added condtion to check dict type

Co-authored-by: prijendev <[email protected]>
Co-authored-by: namrata270998 <[email protected]>
Co-authored-by: namrata270998 <[email protected]>
Co-authored-by: Prijen Khokhani <[email protected]>
@prijendev
Merge branch 'master' into crest-master
f649825
@prijendev
Added tax_type and metadata in subcriptions_items
c92fbb9
@namrata270998
Merged master into crest-master
8811e85
@prijendev
Initial commit for rule map
f199cb7
@prijendev
Added standard_stream name in discover mode
309402f
@prijendev
Added detail comments
e493966
@prijendev
Resolved pylint error
f144545
@prijendev
Added rulemap for event based records
ada7fa5
@prijendev
Resolved pylint errors
ebf2f94
@prijendev
Resolved pylint error
95fe8c0
@prijendev
Resolved rule map error for array type
60af174
@prijendev
Resolved list field missing issue
1be415f
@namrata270998
added the proration_details due to cci failure
f061617
@prijendev
Resolved ref issue.
9e407c1
@prijendev
Added detail comment.
5e9dc87
@prijendev
Resolved conflict issue
38a1aa6
@namrata270998 @prijendev @NevilParikh14
TDL-17880 Add missing test cases (#131)
a87d236 
* Added event_type field in all schemas

* Added test cases for event updates

* Updated __init__ file

* Updated event_type field to updated_by_event_type field name

* Reverted back config.yml file changes

* Updated event_type field in all_field test case.

* Added missing test case assertion

* fixed circleci error and updated tests

* updated integration tests to resolve cci failures

* removed the unused variables

* removed duplicate code

* resolved comments

* added more comments

* added new map for intermittent missing fields

* updated schema missing fields map and changed the union

* added proper comment

Co-authored-by: prijendev <[email protected]>
Co-authored-by: nevilparikh_crest <[email protected]>
@prijendev @namrata270998
Tdl 13149 sync payment intent (#127)
922f568 
* Initial commit for payment_intent stream

* Updated bookmark test case.

* Updated expand parameter for charge stream in utils.py

* Updated utils.py

* Removed payment_intent object from charge stream

* Removed extra field from charges schema

* Added card field in schema

* Updated transfer_group and application_fee_amount field type

* Updated transfer_group field

* Updated datatype of destination field

* Updated transfer_data

* Added payment record creation

* Resolved test case error

* Resloved all fields test case error

* Resolved test case error

* Added comments in test case.

Co-authored-by: namrata270998 <[email protected]>
@namrata270998
Tdl 13711 upgrade json schema (#124)
59a81a2 
* updated the transform_usage type and integration tests

* added plan back to the sub_items

* removed the workaround for the invoices 'created' field

* updated transform_usage type

* added code comment
@prijendev @namrata270998
TDL 15120 add event type field in schemas (#123)
6f6f06e 
* Added event_type field in all schemas

* Added test cases for event updates

* Updated __init__ file

* Updated event_type field to updated_by_event_type field name

* Reverted back config.yml file changes

* Updated event_type field in all_field test case.

Co-authored-by: namrata270998 <[email protected]>
@namrata270998
updated charge.json
0e19967
@prijendev
Resolved pylint error
15a2955
@prijendev
Merge remote-tracking branch 'origin/crest-master' into TDL-17934-poc…
d33160a 
…-on-rulemap-implementation
@prijendev
Skipped card.mandate of charge stream in all_fields test case
c5e5868
@prijendev
Updated rulemap implementation with handling of None value
2435471
@prijendev
Resolved all_fields test case error for payment_intents stream
77b3025
@KrisPersonal KrisPersonal deleted the miro-code branch March 16, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prijendev @KrisPersonal @savan-chovatiya @namrata270998