Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create disputes data for automatic fields #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HarrisonMarcRose
Copy link
Contributor

@HarrisonMarcRose HarrisonMarcRose commented Oct 20, 2022

Description

Circle CI job failure shows

2022-10-17 01:15:49,717 TapTester - INFO     WARN: missing streams: {'disputes'}. consider adding them to the test account
...
...
======================================================================
FAIL: test_run (test_automatic_fields.MinimumSelectionTest) (stream='disputes')
Verify that for each stream you can get multiple pages of data
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/project/tests/test_automatic_fields.py", line 71, in test_run
    self.assertGreater(
  File "/usr/local/share/virtualenvs/tap-tester/lib/python3.9/site-packages/tap_tester/base_case.py", line 71, in logging
    return func(*args, **kwargs)
  File "/usr/local/share/virtualenvs/tap-tester/lib/python3.9/site-packages/tap_tester/base_case.py", line 170, in assertGreater
    return TestCase.assertGreater(super(), *args, **kwargs)
AssertionError: -1 not greater than 0 : The number of records is not over the stream max limit

This change creates data for the stream so records will be in the sync

Manual QA steps

  • Ran the test with the changes

Risks

Rollback steps

  • revert this branch

@HarrisonMarcRose HarrisonMarcRose force-pushed the qa/automatic-fields_add-disputes branch from 962df13 to 60da80c Compare October 21, 2022 13:49
@bhtowles bhtowles force-pushed the qa/automatic-fields_add-disputes branch from 60da80c to 708c5a2 Compare January 9, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants