Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tap-stripe] "Update events" persistence results in null values overwriting non-null fields #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shantanu73
Copy link

@shantanu73 shantanu73 commented Feb 26, 2024

Description of change

Add billing_reason as key property for invoices stream. This is done so that all the records
fetched from invoices stream are persisted while loading the data to customer's destination
instead of getting overridden by updates which are captured using events stream.

Manual QA steps

  • Ran sync locally

Risks

  • This may be a Major release as a new key property is added.

Rollback steps

  • revert this branch

1) Fixed the incorrectly modified payment_intents stream and added the invoice stream changes.
2) Fixed integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant