Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View install commands #596

Merged
merged 11 commits into from
Oct 12, 2022
Merged

View install commands #596

merged 11 commits into from
Oct 12, 2022

Commits on Oct 10, 2022

  1. Removed the --view option of shpc install 

    as per singularityhub#590 (comment)
    @muffato
    muffato committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    df5589e View commit details
    Browse the repository at this point in the history

  2. bugfix: always install in the default view, alongside additionally re… 

    …quested views

Renamed the variables to make it clear what is a view and what is a view name.
    @muffato
    muffato committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5ba70a2 View commit details
    Browse the repository at this point in the history

  3. Print what bash is running

    @muffato
    muffato committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7e93b13 View commit details
    Browse the repository at this point in the history

  4. Test views on tcsh too

    @muffato
    muffato committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7677670 View commit details
    Browse the repository at this point in the history

  5. Moved the code to install a module into a view to a separate function

    @muffato
    muffato committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    05697df View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. addition of intermediate module class 

    This will help to carry around some common data
attributes and functions, and reduce redundancy within
the ModuleBase class. It also allows for providing
fewer variables to the rendered templates since
they can come from the module.

Signed-off-by: vsoch <[email protected]>
    @vsoch @muffato
    vsoch authored and muffato committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    048f677 View commit details
    Browse the repository at this point in the history

  2. ensure we maintain parsed name 

    Signed-off-by: vsoch <[email protected]>
    @vsoch @muffato
    vsoch authored and muffato committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2a1331a View commit details
    Browse the repository at this point in the history

  3. Moved the view uninstallation to a separate function to mirror view_i… 

    …nstall
    @muffato
    muffato committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b3121e9 View commit details
    Browse the repository at this point in the history

  4. No need to make this local variable 

    Co-authored-by: Vanessasaurus <[email protected]>
    @muffato @vsoch
    muffato and vsoch authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b89b823 View commit details
    Browse the repository at this point in the history

  5. Use parsed_name for consistency 

    config.name was not wrong

Co-authored-by: Vanessasaurus <[email protected]>
    @muffato @vsoch
    muffato and vsoch authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    eec370c View commit details
    Browse the repository at this point in the history

  6. Document the "force" flags

    @muffato
    muffato committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    7e76b6b View commit details
    Browse the repository at this point in the history