Skip to content

[ENH] EXPERIMENTAL: Example notebook based on the new data pipeline #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 64 commits into
base: main
Choose a base branch
from

Conversation

phoeenniixx
Copy link
Contributor

@phoeenniixx phoeenniixx commented Apr 6, 2025

Description

This PR adds example notebook for the new v2 data pipeline vignette, having the basic implementation of the tft model using this version. For more info see #1812 , #1811

Colab link: https://colab.research.google.com/drive/148MyhcNfYEh4CZ6vBXLqQNsUBF0n6_0v?usp=sharing

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@phoeenniixx
Copy link
Contributor Author

Hi @fkiraly, I am getting this error:
image

I just downloaded the notebook from colab and pasted it in the repo, is there anything else I should do to avoid this? Really have no idea 😅

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 173 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4c30351). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ting/models/temporal_fusion_transformer/_tft_v2.py 0.00% 97 Missing ⚠️
pytorch_forecasting/models/base/_base_model_v2.py 0.00% 76 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1813   +/-   ##
=======================================
  Coverage        ?   84.20%           
=======================================
  Files           ?       53           
  Lines           ?     5836           
  Branches        ?        0           
=======================================
  Hits            ?     4914           
  Misses          ?      922           
  Partials        ?        0           
Flag Coverage Δ
cpu 84.20% <0.00%> (?)
pytest 84.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly moved this from PR in progress to PR under review in May - Sep 2025 mentee projects May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under review
Development

Successfully merging this pull request may close these issues.

2 participants