-
Notifications
You must be signed in to change notification settings - Fork 683
Allow direct initialization of NBeats model without from_dataset #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow direct initialization of NBeats model without from_dataset #1837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
=======================================
Coverage ? 86.86%
=======================================
Files ? 51
Lines ? 5673
Branches ? 0
=======================================
Hits ? 4928
Misses ? 745
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Quick question, why are we changing the old test? Does this mean existing code breaks?
We should avoid to break working code of users.
Hi @fkiraly, Passing a list of length 3 was causing the following error:
Let me know if you'd like to handle this differently! |
Can you explain why the |
Description
This PR fixes issue #1548 where the NBeats model fails when initialized without using the
from_dataset
method. The changes enable direct initialization while maintaining backward compatibility and adding proper validation.Changes
__init__
method with comprehensive parameter validationfrom_dataset
method documentation to clarify its roleNow users can:
from_dataset
(recommended) for standard time series forecastingExample of direct initialization:
Checklist
pre-commit install
.To run hooks independent of commit, execute
pre-commit run --all-files
Make sure to have fun coding!