fixed reviews math

skucheria · Sep 10, 2019 · 9979647 · 9979647
1 parent 47cf803
commit 9979647
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Helpers/Extensions.swift b/Helpers/Extensions.swift
@@ -68,7 +68,6 @@ extension UIViewController{
                             user.fcmToken = item.value["fcmToken"] as? String
                             user.numReviews = item.value["numReviews"] as? Float
                             user.reviews = item.value["reviews"] as? [String]
-
                         }
                     }
                 }

diff --git a/LearnLab.xcworkspace/xcuserdata/siddharth.xcuserdatad/UserInterfaceState.xcuserstate b/LearnLab.xcworkspace/xcuserdata/siddharth.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/LearnLab/ViewControllers/NewReviewVC.swift b/LearnLab/ViewControllers/NewReviewVC.swift
@@ -138,7 +138,6 @@ class NewReviewVC: UIViewController, UITextViewDelegate {
 
 
     @objc func review(){
-        print("Leaving review with rating: ", stars.rating)
         //for grouped reviews
         let ref = Database.database().reference().child("grouped-reviews").child(currentTutor!)
         let revRef = ref.childByAutoId()
@@ -165,9 +164,13 @@ class NewReviewVC: UIViewController, UITextViewDelegate {
         else{
             // do the math here
             let starRate : Float = Float(stars.rating)
+            var newRating : Float = (oldRating * numReview) + starRate
             numReview += 1
-            var newRating : Float = (oldRating + numReview) + starRate
             newRating = newRating / numReview
+            print("Old overall rating: ", oldRating)
+            print("Total num of reviews now ", numReview)
+            print("New rating ", starRate)
+            print("Overall new rating ", newRating)
             userRef.child(curr!.id!).updateChildValues(["rating" : newRating, "numReviews" : numReview])
         }
         var oldReviews = [String]()
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,6 @@ extension UIViewController{ @@
                                 user.fcmToken = item.value["fcmToken"] as? String
                                 user.numReviews = item.value["numReviews"] as? Float
                                 user.reviews = item.value["reviews"] as? [String]
                             }
                         }
                     }
@@ Expand Down @@