Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary Vast AI support #4365

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

kristopolous
Copy link

@kristopolous kristopolous commented Nov 15, 2024

This is preliminary support for Vast. It currently works on an unreleased version of the SDK which we will soon get up to PyPy

The document https://docs.google.com/document/d/1oWox3qb3Kz3wXXSGg9ZJWwijoa99a3PIQUHBR8UgEGs/edit?pli=1&tab=t.0 was followed and all the testing passed

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

I'm pretty sure there will need to be edits, I'm fine with that. This is attempt 1. The outstanding work:

We need to

  • tidy up our dockerhub and will get a better image to launch.
  • release the updates to the sdk and come up with a pip name for it.
  • get our catalog to update in the git hook flow as described (my goal is every 6 hours)

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this @kristopolous ! This is really exciting. Left some discussions. One main confusion I have is that, does vast ai like runpod, a cloud providing pods to users as their "VM"s? Asking because I'm seeing a lot of docker related code, and just want to confirm :)

sky/adaptors/vast.py Show resolved Hide resolved
sky/clouds/vast.py Show resolved Hide resolved
Comment on lines 34 to 37
clouds.CloudImplementationFeatures.STORAGE_MOUNTING:
('Mounting object stores is not supported on Vast. To read data '
'from object stores on Vast, use `mode: COPY` to copy the data '
'to local disk.'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, is this not supported as well? This seems only not enabled in runpod for now, which I suppose is due to its pod nature for provisioned "VM"s. Is vast ai also provide pods to the user?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a copy/paste. We're actually working on releasing storage by the end of the calendar year. Right now, purchasing additional storage through us is not supported. I will change this to be more reflective of the current state of things.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 98e3db5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure, it sounds like you are referring to cloud storage from VastAI? IIUC this feature actually means can you mount storages from any cloud (e.g. S3, GCS) in the VastAI clusters, and it should be supported as long as some mounting utils is supported. Though if VastAI using the same container fashion provisioning, it might not work as well. cc @romilbhardwaj - what is the reason runpod not support this feature?

sky/clouds/vast.py Show resolved Hide resolved
sky/clouds/vast.py Outdated Show resolved Hide resolved
sky/provision/vast/utils.py Show resolved Hide resolved
sky/provision/vast/utils.py Show resolved Hide resolved
sky/provision/vast/instance.py Outdated Show resolved Hide resolved
sky/provision/vast/instance.py Show resolved Hide resolved
sky/provision/vast/instance.py Show resolved Hide resolved
@kristopolous
Copy link
Author

Thanks for contributing to this @kristopolous ! This is really exciting. Left some discussions. One main confusion I have is that, does vast ai like runpod, a cloud providing pods to users as their "VM"s? Asking because I'm seeing a lot of docker related code, and just want to confirm :)

historically, runpod was a clone of vast. We currently offer docker-style containers and will be providing vms soonish (probably before end of year)

@kristopolous kristopolous force-pushed the vast.ai-support branch 3 times, most recently from e9e922a to 4c9aff9 Compare November 21, 2024 22:28
@kristopolous
Copy link
Author

these test passing is blocked by https://github.com/skypilot-org/skypilot-catalog/pull/100/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants