Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show logs for storage mount #4387

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Nov 20, 2024

Feature for #4105

  • All storage object uploads will get a new temp file and log to this temp file.
image
(sky) ➜  skypilot git:(dev/zeping/show_logs_for_storage_mount) ✗ cat ~/Desktop/hello-sky/work_dir_2.yaml
resources:
  cloud: aws

file_mounts:
  ~/aws: ~/Desktop/dir2

  /datasets-storage:
    name: sky-dataset
    source: ~/Desktop/dir2 
    persistent: True
    mode: MOUNT

workdir: ~/Desktop/dir1

num_nodes: 1

run: |
  echo "Hello, world!"
  ls ~/aws
  ls /datasets-storage
sky jobs launch ~/Desktop/hello-sky/work_dir_2.yaml
image

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (3)

sky/data/storage.py:1002

  • The variable 'self.source' should be 'source' to match the function parameter.
logger.warning(f'\'.git\' directory under \'{self.source}\' ' 'is excluded during sync.')

sky/data/data_utils.py:541

  • The error message has a grammatical error. It should be 'No file uploaded. This could be due to an error or because all files already exist on the cloud.'
storage_logger.info('No file uploaded, could be error happened or all files already exist on cloud')

sky/data/data_utils.py:531

  • [nitpick] The variable name 'stdout_line_write_cnt' is not very descriptive. Consider renaming it to 'stdout_line_count'.
stdout_line_write_cnt = 0
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zpoint!

sky/sky_logging.py Outdated Show resolved Hide resolved
sky/data/storage.py Outdated Show resolved Hide resolved
sky/data/data_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zpoint! Works nicely. Should be good to go after the two comments are resolved.

sky/data/data_utils.py Outdated Show resolved Hide resolved
sky/sky_logging.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants