Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for test kubernetes example #4426

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Nov 28, 2024

The current command in the doc doesn't work

ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=Master version "1.29.1-gke.1589020" is unsupported.
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=Master version must be one of "REGULAR" channel supported versions [1.28.14-gke.1340000, 1.28.14-gke.1376000, 1.28.15-gke.1020000, 1.29.9-gke.1496000, 1.29.9-gke.1541000, 1.29.10-gke.1054000, 1.30.5-gke.1443001, 1.30.5-gke.1699000, 1.31.1-gke.1846000, 1.31.1-gke.2008000, 1.31.1-gke.2105000].

Official doc of supported version

Fetch version from gcloud, then apply it in the command

Splace reformated by pre-commit

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@zpoint zpoint changed the title update readme for smoke test kubernetes example update readme for test kubernetes example Nov 28, 2024
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zpoint!

tests/kubernetes/README.md Outdated Show resolved Hide resolved
@zpoint zpoint added this pull request to the merge queue Dec 3, 2024
Merged via the queue into skypilot-org:master with commit 5c1cb9c Dec 3, 2024
19 checks passed
@zpoint zpoint deleted the dev/zeping/update_test_doc branch December 3, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants