Skip to content

Fix Ninja not beeing found on Windows testbed Ci #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Fancy2209
Copy link

Should fix the issue that made the following run fail:
https://github.com/skypjack/entt/actions/runs/14351371989

@Fancy2209 Fancy2209 changed the title Fix Ninja not beeing found on Windows' Testbed Ci Fix Ninja not beeing found on Windows testbed Ci May 14, 2025
@Fancy2209
Copy link
Author

Oh wait I just realized, windows-latest is still 2022 and winget is only available on windows-2025, I'll fix this to another method when I can, my bad

@Fancy2209 Fancy2209 marked this pull request as draft May 14, 2025 08:43
@Fancy2209
Copy link
Author

Oh no it seems the readme for the actions containers is just outdated and it is windows-2025?

@Fancy2209 Fancy2209 marked this pull request as ready for review May 14, 2025 08:47
@skypjack
Copy link
Owner

The testbed workflow is is fixed already on the wip branch. See here. Is this what you're trying to do? In this case, we can safely close the PR as done 👍

@skypjack skypjack self-requested a review May 16, 2025 13:05
@skypjack skypjack self-assigned this May 16, 2025
@skypjack skypjack added the triage pending issue, PR or whatever label May 16, 2025
@Fancy2209
Copy link
Author

The testbed workflow is is fixed already on the wip branch. See here. Is this what you're trying to do? In this case, we can safely close the PR as done 👍

Oh yep, my bad

@Fancy2209 Fancy2209 closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage pending issue, PR or whatever
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants