Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support latest aws provider. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gurpalw
Copy link

@gurpalw gurpalw commented Jan 21, 2021

Description

Related Issue

Motivation and Context

the below error appears when using this module with the latest aws provider v3.2.x

Error: Unsupported argument

on .terraform/modules/cassandra-iam/instance_profile/main.tf line 3, in resource "aws_iam_instance_profile" "profile":
3: roles = [aws_iam_role.role.name]

An argument named "roles" is not expected here. Did you mean "role"?

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have followed the PR process as described here
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Error: Unsupported argument

  on .terraform/modules/cassandra-iam/instance_profile/main.tf line 3, in resource "aws_iam_instance_profile" "profile":
   3:   roles = [aws_iam_role.role.name]

An argument named "roles" is not expected here. Did you mean "role"?
@iuriaranda
Copy link
Contributor

Thanks for your contribution.

Could you add a version constraint for the aws provider inside the module? That will help with current installs of this module and will force users to use a newer version of the provider.

Something like:

terraform {
  required_providers {
    aws = {
      version = ">= 3.26.0"
      source = "hashicorp/aws"
    }
  }
}

There's already a terraform block in the versions.tf file that you can reuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants