Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non_canonical_partial_ord_impl
It seems like
partial_cmp
never returnNone
, so I made small change of it.The new implementation has a small logic change from the previous one, since arguments passed to
Ordering::then
are eagerly evaluated.I pefer it because it's more succinct than
Ordering::then_with
and without notable performace penalty. That's enough for an educational project.manual_clamp
My rust version is
rustc 1.79.0 (129f3b996 2024-06-10)
, so there are new clippy warnnings, list below.assigning_clones
It looks lik
assigning_clones
is allowed by default from the webpage, but when I runcargo clippy
, I get a warning.legacy_numeric_constants
missing_transmute_annotations