Improve eslint setup (#995)

.changeset/proud-schools-smile.md

@@ -0,0 +1,47 @@
+---
+"@sl-design-system/inline-message": patch
+"@sl-design-system/message-dialog": patch
+"@sl-design-system/breadcrumbs": patch
+"@sl-design-system/radio-group": patch
+"@sl-design-system/editorial-suite": patch
+"@sl-design-system/my-digital-book": patch
+"@sl-design-system/sanoma-learning": patch
+"@sl-design-system/button-bar": patch
+"@sl-design-system/text-field": patch
+"@sl-design-system/checkbox": patch
+"@sl-design-system/skeleton": patch
+"@sl-design-system/textarea": patch
+"@sl-design-system/popover": patch
+"@sl-design-system/spinner": patch
+"@sl-design-system/tooltip": patch
+"@sl-design-system/itslearning": patch
+"@sl-design-system/avatar": patch
+"@sl-design-system/button": patch
+"@sl-design-system/dialog": patch
+"@sl-design-system/drawer": patch
+"@sl-design-system/editor": patch
+"@sl-design-system/select": patch
+"@sl-design-system/shared": patch
+"@sl-design-system/switch": patch
+"@sl-design-system/bingel-int": patch
+"@sl-design-system/badge": patch
+"@sl-design-system/bingel-dc": patch
+"@sl-design-system/card": patch
+"@sl-design-system/form": patch
+"@sl-design-system/grid": patch
+"@sl-design-system/icon": patch
+"@sl-design-system/menu": patch
+"@sl-design-system/tabs": patch
+"@sl-design-system/clickedu": patch
+"@sl-design-system/magister": patch
+"@sl-design-system/nowa-era": patch
+"@sl-design-system/myvanin": patch
+"@sl-design-system/bingel": patch
+"@sl-design-system/kampus": patch
+"@sl-design-system/neon": patch
+"@sl-design-system/teas": patch
+"@sl-design-system/max": patch
+"@sl-design-system/locales": patch
+---
+
+Linting fixes due to new eslint configuration

.changeset/tame-spiders-join.md

@@ -0,0 +1,5 @@
+---
+"@sl-design-system/eslint-config": patch
+---
+
+New packages containing the ESLint config

.gitignore

@@ -61,6 +61,7 @@ packages/components/**/*.d.ts
 packages/components/**/*.d.ts.map
 packages/components/**/*.js
 packages/components/**/*.js.map
+!packages/components/eslint.config.js
 packages/locales/**/*.d.ts
 packages/locales/**/*.d.ts.map
 packages/locales/**/*.js
@@ -69,6 +70,7 @@ packages/themes/**/*.d.ts
 packages/themes/**/*.d.ts.map
 packages/themes/**/*.js
 packages/themes/**/*.js.map
+!packages/themes/eslint.config.js
 website/build
 website/dist
 

.lintstagedrc.cjs

@@ -1,4 +1,4 @@
 module.exports = {
   '*.scss': 'stylelint --fix',
-  '*.ts': 'eslint --fix'
+  'packages/components/**/*.ts': 'eslint --config packages/components/eslint.config.js --fix'
 };

.vscode/settings.json

@@ -4,6 +4,7 @@
   },
   "editor.detectIndentation": false,
   "editor.tabSize": 2,
+  "eslint.experimental.useFlatConfig": true,
   "eslint.format.enable": true,
   "[typescriptreact]": {
     "editor.defaultFormatter": "dbaeumer.vscode-eslint"

eslint.config.js

@@ -0,0 +1,4 @@
+import config from '@sl-design-system/eslint-config';
+
+/** @type {import('eslint').Linter.FlatConfig[]} */
+export default [...config];

package.json

@@ -6,6 +6,7 @@
     "type": "git",
     "url": "https://github.com/sl-design-system/components.git"
   },
+  "type": "module",
   "workspaces": [
     "chromatic",
     "packages/angular",
@@ -14,7 +15,9 @@
     "packages/themes/*",
     "packages/tokens",
     "scripts",
+    "tools/eslint-config",
     "tools/example-data",
+    "tools/stylelint-config",
     "website"
   ],
   "scripts": {
@@ -27,7 +30,6 @@
     "lint": "wireit",
     "postinstall": "husky || true",
     "release": "wireit",
-    "reset": "wireit",
     "start": "wireit",
     "storybook": "wireit",
     "test": "wireit",
@@ -147,7 +149,8 @@
       "output": [
         "packages/themes/**/*.{css,json,scss}",
         "!packages/themes/*/fonts.css",
-        "!packages/themes/*/{package,tsconfig}.json"
+        "!packages/themes/*/{package,tsconfig}.json",
+        "!packages/themes/tsconfig.json"
       ]
     },
     "build:types": {
@@ -175,7 +178,7 @@
       ]
     },
     "lint:components": {
-      "command": "eslint \"packages/components/**/!(*.{d,spec}).ts\""
+      "command": "eslint --config packages/components/eslint.config.js packages/components/*"
     },
     "release": {
       "command": "yarn changeset publish",
@@ -184,9 +187,6 @@
         "./packages/angular:release"
       ]
     },
-    "reset": {
-      "command": "rimraf --glob \"**/.wireit\""
-    },
     "start": {
       "command": "storybook dev -p 6006 --no-open",
       "service": {
@@ -289,7 +289,6 @@
     }
   },
   "devDependencies": {
-    "@11ty/eleventy": "^2.0.1",
     "@changesets/cli": "^2.27.1",
     "@changesets/get-github-info": "^0.6.0",
     "@custom-elements-manifest/analyzer": "^0.9.2",
@@ -300,34 +299,29 @@
     "@storybook/addon-essentials": "^7.6.17",
     "@storybook/addon-storysource": "^7.6.17",
     "@storybook/web-components-vite": "^7.6.17",
+    "@types/chai-as-promised": "^7.1.8",
     "@types/mocha": "^10.0.6",
-    "@typescript-eslint/eslint-plugin": "^6.10.0",
-    "@typescript-eslint/parser": "^6.10.0",
+    "@types/sinon": "^17.0.3",
     "@web/dev-server-esbuild": "^1.0.2",
     "@web/test-runner": "^0.18.0",
     "@web/test-runner-commands": "^0.9.0",
     "@web/test-runner-playwright": "^0.11.0",
     "@webcomponents/scoped-custom-element-registry": "^0.0.9",
+    "chai": "npm:@esm-bundle/[email protected]",
+    "chai-as-promised": "npm:@esm-bundle/chai-as-promised@*",
     "chromatic": "^7.6.0",
-    "eslint": "^8.51.0",
-    "eslint-config-prettier": "^8.8.0",
-    "eslint-import-resolver-typescript": "^3.5.5",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-unused-imports": "^2.0.0",
+    "eslint": "^8.57.0",
     "husky": "^9.0.11",
     "lint-staged": "^15.2.2",
     "lit": "^3.1.2",
-    "prettier": "^2.8.8",
+    "prettier": "2.8.8",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "rimraf": "^5.0.5",
-    "sass": "^1.71.1",
     "sinon": "^17.0.1",
     "storybook": "^7.6.17",
-    "stylelint": "^15.9.0",
-    "stylelint-config-sass-guidelines": "^9.0.1",
-    "stylelint-prettier": "^3.0.0",
+    "stylelint": "15.9.0",
+    "stylelint-config-sass-guidelines": "9.0.1",
+    "stylelint-prettier": "3.0.0",
     "typescript": "^5.3.3",
     "vite": "^5.1.3",
     "wireit": "^0.14.4"