Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #91

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Refactoring #91

wants to merge 18 commits into from

Conversation

Nindemic
Copy link
Collaborator

@Nindemic Nindemic commented Jul 27, 2021

WIP

  • Rectifies root module placements
  • Version upgrades
  • Unnecessary comments are deleted or cleaned
  • Updates READ.ME with correct service stack deployment instructions

@Nindemic Nindemic added the question Further information is requested label Jul 27, 2021
@Nindemic Nindemic force-pushed the refactoring branch 5 times, most recently from fba2ef9 to 6109598 Compare August 16, 2021 14:03
02_deployHono/main.tf Outdated Show resolved Hide resolved
02_deployHono/main.tf Outdated Show resolved Hide resolved
@msrn msrn added this to the Hono deployment milestone Nov 6, 2021
Nindemic added 7 commits December 13, 2021 15:54
 * All root modules moved to the same directory level
 * Root modules are numbered according to apply order
 * Fixes Smad service stack deployment instructions
 * Updates READ.ME
 * Upgrades provider version
 * Unnecessary files, variables and comments are deleted

Signed-off-by: Nindemic <[email protected]>
  * Divides container_deployment into separate modules
  * Ambassador, Mongo, Jaeger and Prometheus_stack have separate modules

Signed-off-by: Nindemic <[email protected]>
  * Module container_registry is moved and renamed as a root module
  * Documentation is updates

Signed-off-by: Nindemic <[email protected]>
Signed-off-by: Nindemic <[email protected]>
Signed-off-by: Nindemic <[email protected]>
  *Adds mongoDB storage for telemetry data
  *Adds Kafka mongoDB connector

Signed-off-by: Nindemic <[email protected]>
@Nindemic Nindemic force-pushed the refactoring branch 4 times, most recently from cb2182d to 53cdb65 Compare December 13, 2021 16:00
    * Update documentation
    * Fixes READ.ME instructions for module deployment
    * Updates docs/ARCHITECTURE.md
    * Updates docs/SETUP.md

Signed-off-by: Nindemic <[email protected]>
Comment on lines +24 to +27
bootstrap.servers: kafka-0.kafka-headless.default.svc.cluster.local:9092
security.protocol: SASL_PLAINTEXT
sasl.mechanism: SCRAM-SHA-512
sasl.jaas.config: "org.apache.kafka.common.security.scram.ScramLoginModule required username=\"hono\" password=\"hono-secret\";"
Copy link
Member

@msrn msrn Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configure Hono to authenticate with custom kafka as common client

Comment on lines 37 to 39
jaas:
clientUser: hono
clientPassword: hono-secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These option were deprecated on the kafka chart

terraform:
name: 'Terraform Validate and plan'
test_storagerg_module:
name: 'Test and deploy 01_Storage_rg module with Terraform Validate and plan'
Copy link
Member

@msrn msrn Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow now tests and deploys the storagerg module to Azure. Deployhono -module plan would fail because that module needs outputs of storagerg -module shares. Because of this storage_rg needs to be deployed.

run: terraform apply -auto-approve

test_deployhono_module:
name: 'Test 02_deploy_hono module with Terraform Validate and plan'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test deployHono module with validate and plan.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this workflow here
msrn#5
You can see output of checks here
https://github.com/msrn/smad-deploy-azure/actions/runs/1663019863

@@ -61,6 +108,40 @@ jobs:
id: plan
run: terraform plan
#continue-on-error: true

destroy_storagerg_module:
name: 'Destroy 01_Storage_rg module from Azure subscription'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destroy previously made storagerg

@msrn msrn added safe-to-test PR's that are safe to test with the pipeline and removed safe-to-test PR's that are safe to test with the pipeline labels Jan 6, 2022
  *Deployment was failing due to wrong deployment order

Signed-off-by: Nindemic <[email protected]>
msrn added 3 commits January 11, 2022 10:38
Signed-off-by: Mikael Saarinen <[email protected]>
Signed-off-by: Mikael Saarinen <[email protected]>
Signed-off-by: Mikael Saarinen <[email protected]>
Nindemic added 3 commits January 31, 2022 17:50
Signed-off-by: Nindemic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants